Chrome e2e tests #344
Closed
Chrome e2e tests #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
requested changes
Mar 27, 2019
foresthoffman
force-pushed
the
feat/e2e
branch
8 times, most recently
from
60e5c98 to
cd69a0f
Compare
|
Just had a thought that it might be good to run the tests as Mac, Windows, and Linux clients. Those values are set based on the user agent, could possibly set that? |
|
@code-asher It is possible to set the user agent for a page with puppeteer: https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagesetuseragentuseragent. I think it uses the base platform to determine the user agent. |
foresthoffman
force-pushed
the
feat/e2e
branch
5 times, most recently
from
c483146 to
c3c3216
Compare
foresthoffman
requested review from
kylecarbs and
code-asher
and removed request for
kylecarbs and
code-asher
foresthoffman
force-pushed
the
feat/e2e
branch
2 times, most recently
from
b0c240e to
dcc1c2e
Compare
foresthoffman
requested review from
kylecarbs and
code-asher
and removed request for
kylecarbs and
code-asher
added 8 commits
April 23, 2019 18:38
added 4 commits
April 25, 2019 21:22
$TRAVIS_JOB_NUMBER is unreliable, as it outputs the currently running job number ($TRAVIS_BUILD_NUMBER.XX) which seems to be the job that was started last.
foresthoffman
force-pushed
the
feat/e2e
branch
3 times, most recently
from
4e362b1 to
6e30eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
--portflag--passwordflag--allow-httpflag--no-authflagIs there an open issue you can link to?
Fixes #339